Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create no-restricted-jest-methods rule #1257

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Oct 3, 2022

Resolves #1256

@mrazauskas
Copy link
Contributor

That was quick. Thanks!

@G-Rath G-Rath force-pushed the create-no-restricted-jest-methods branch from fe5ba1f to 04354cb Compare October 3, 2022 18:38
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff - very clean implementation 👍

@SimenB SimenB merged commit b8e61b1 into main Oct 3, 2022
@SimenB SimenB deleted the create-no-restricted-jest-methods branch October 3, 2022 21:06
github-actions bot pushed a commit that referenced this pull request Oct 3, 2022
# [27.1.0](v27.0.4...v27.1.0) (2022-10-03)

### Features

* create `no-restricted-jest-methods` rule ([#1257](#1257)) ([b8e61b1](b8e61b1))
## Rule details

This rule checks for the usage of specific methods on the `jest` object, which
can be used to disallow curtain patterns such as spies and mocks.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just for my non native speaker understanding - are we really talking about curtain patterns here or is this a typo of certain patterns?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo 😀

wanna send a PR fixing it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More than happy to, coming right up

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Primajin added a commit to Primajin/eslint-plugin-jest that referenced this pull request Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New rule to disallow using mock API in end-to-end test files
4 participants